Skip to content

Fix/univ search cache error#792

Merged
yoonc01 merged 1 commit into
developfrom
fix/univ-search-cache-error
Jun 24, 2026
Merged

Fix/univ search cache error#792
yoonc01 merged 1 commit into
developfrom
fix/univ-search-cache-error

Conversation

@yoonc01

@yoonc01 yoonc01 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

관련 이슈

캐시 문제로 인해 대학 리스트 출력 불가
image

작업 내용

주석 처리가 미 완성되어 있어 주석 처리를 했습니다.

@yoonc01 yoonc01 self-assigned this Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@yoonc01, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 39 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 896c6c43-7ec3-43f0-bb59-160e33a05d41

📥 Commits

Reviewing files that changed from the base of the PR and between 5ebc9c8 and 477a546.

📒 Files selected for processing (1)
  • src/main/java/com/example/solidconnection/university/service/UnivApplyInfoQueryService.java

Walkthrough

이번 PR에는 두 가지 어노테이션 관련 변경이 포함되어 있어요. 😊

  1. JSON 직렬화 동작 변경 (MyPageResponse)

    • homeUniversityName 필드에 붙어 있던 @JsonInclude(NON_NULL) 어노테이션이 제거되었어요.
    • 이제 해당 필드 값이 null이더라도 JSON 응답에 포함될 수 있어요.

  2. 캐시 비활성화 (UnivApplyInfoQueryService)

    • searchUnivApplyInfoByText 메서드에 적용되어 있던 @ThunderingHerdCaching 어노테이션이 주석 처리로 비활성화되었어요.
    • 텍스트 기반 대학교 지원 정보 검색 결과에 대한 캐시가 더 이상 적용되지 않아요.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • Gyuhyeok99
  • wibaek
  • whqtker
  • lsy1307
  • Hexeong
  • JAEHEE25
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed 제목이 대학 검색 캐시 오류 수정이라는 주요 변경점을 간결하게 설명합니다.
Description check ✅ Passed 관련 이슈와 작업 내용이 포함되어 있고, 필수 섹션 대부분을 충족합니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/univ-search-cache-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yoonc01 yoonc01 force-pushed the fix/univ-search-cache-error branch from 5ebc9c8 to 477a546 Compare June 24, 2026 15:20
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jun 24, 2026

Copy link
Copy Markdown

💡 Codex Review

solid-connect-server/src/main/java/com/example/solidconnection/siteuser/dto/MyPageResponse.java

Line 30 in 5ebc9c8

String homeUniversityName) {

P2 Badge Preserve null omission for homeUniversityName

When a user has no homeUniversityId (for example an unverified mentee or a mentor), MyPageService.findHomeUniversityName() returns null; removing the component-level @JsonInclude(NON_NULL) makes /my-page start serializing "homeUniversityName": null instead of omitting it, while the other role-specific nullable fields still omit nulls. This is an unintended API shape change unrelated to the cache fix and can break clients that distinguish absent optional fields from explicit nulls.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

coderabbitai[bot]
coderabbitai Bot reviewed Jun 24, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/main/java/com/example/solidconnection/university/service/UnivApplyInfoQueryService.java (1)

45-46: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

  1. 캐시 비활성화 임시조치에 “재적용 조건”을 코드로 고정해 주세요.
    • Line 46에서 @ThunderingHerdCaching를 주석 처리하면 검색 트래픽이 DB로 직행해 피크 구간 성능 리스크가 커집니다.
    • 주석만 두기보다 TODO(#이슈번호/기한) 또는 feature flag로 복구 경로를 명시해, 임시조치가 영구화되지 않게 해주세요.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/main/java/com/example/solidconnection/university/service/UnivApplyInfoQueryService.java`
around lines 45 - 46, 현재 `UnivApplyInfoQueryService`의 `@ThunderingHerdCaching`가
주석 처리된 임시 비활성화 상태를 그대로 두지 말고, 이 캐시 복구 조건을 코드에 고정해 주세요. `univApplyInfoTextSearch`
경로에서 캐시를 끄는 이유와 재적용 기준을 `TODO(`#이슈번호/기한`)`으로 명시하거나, `@ThunderingHerdCaching`을
feature flag로 제어하도록 바꿔 임시조치가 영구화되지 않게 하세요.
🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@src/main/java/com/example/solidconnection/university/service/UnivApplyInfoQueryService.java`:
- Around line 45-46: 현재 `UnivApplyInfoQueryService`의 `@ThunderingHerdCaching`가
주석 처리된 임시 비활성화 상태를 그대로 두지 말고, 이 캐시 복구 조건을 코드에 고정해 주세요. `univApplyInfoTextSearch`
경로에서 캐시를 끄는 이유와 재적용 기준을 `TODO(`#이슈번호/기한`)`으로 명시하거나, `@ThunderingHerdCaching`을
feature flag로 제어하도록 바꿔 임시조치가 영구화되지 않게 하세요.
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6ac7d7e1-5dda-407c-86c5-5838152d9e91

📥 Commits

Reviewing files that changed from the base of the PR and between f14b384 and 5ebc9c8.

📒 Files selected for processing (2)
  • src/main/java/com/example/solidconnection/siteuser/dto/MyPageResponse.java
  • src/main/java/com/example/solidconnection/university/service/UnivApplyInfoQueryService.java
💤 Files with no reviewable changes (1)
  • src/main/java/com/example/solidconnection/siteuser/dto/MyPageResponse.java

@yoonc01 yoonc01 added the 버그 Something isn't working label Jun 24, 2026
@yoonc01 yoonc01 merged commit eb0a30c into develop Jun 24, 2026
4 checks passed
@yoonc01 yoonc01 deleted the fix/univ-search-cache-error branch June 24, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@whqtker whqtker whqtker approved these changes
@Gyuhyeok99 Gyuhyeok99 Awaiting requested review from Gyuhyeok99 Gyuhyeok99 is a code owner
@wibaek wibaek Awaiting requested review from wibaek wibaek is a code owner
@lsy1307 lsy1307 Awaiting requested review from lsy1307 lsy1307 is a code owner
@Hexeong Hexeong Awaiting requested review from Hexeong Hexeong is a code owner
@JAEHEE25 JAEHEE25 Awaiting requested review from JAEHEE25 JAEHEE25 is a code owner
@sukangpunch sukangpunch Awaiting requested review from sukangpunch sukangpunch is a code owner

Assignees

@yoonc01 yoonc01

Labels

버그 Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yoonc01 @whqtker